Implement contactListMapFromJson() and contactListMapToJson() methods #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S-Dafarra
reviewed
May 27, 2021
src/Contacts/include/BipedalLocomotion/Contacts/ContactListParser.h
Outdated
Show resolved
Hide resolved
GiulioRomualdi
force-pushed
the
feature/contact_parser
branch
2 times, most recently
from
9f3ca6c
to
83225a1
Compare
GiulioRomualdi
force-pushed
the
feature/contact_parser
branch
from
83225a1
to
1e8c53a
Compare
|
@traversaro before merging (or just after) the PR we should add:
|
|
@S-Dafarra if you agree I can merge the PR |
S-Dafarra
reviewed
Jun 1, 2021
| * Parse a ContactListMap from a JSON file. | ||
| * @param filename the name of the file that should be loaded. | ||
| * @return return a ContactListMap containing all the contacts. | ||
| * @note The JSON file should have the following structure |
There was a problem hiding this comment.
Suggested change
| * @note The JSON file should have the following structure | |
| * @note The JSON file should have a structure similar to the following example. |
There was a problem hiding this comment.
Also, it would be nice to comment somewhere why the index is always -1. For example, you could mention that those parameters are the same of Contact. Also, left and right should resemble more a custom name, like my_left_foot.
There was a problem hiding this comment.
Here I did some modifications f14c9d6
what do you think?
paolo-viceconte
approved these changes
Jun 7, 2021
There was a problem hiding this comment.
It looks good to me.
As a doublecheck, I also tried to store a sequence of footsteps from hadherent through contact_list_map_to_json(), which then @GiulioRomualdi was able to read.
S-Dafarra
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #315 in detail I used nlohmann json to parse the JSON file.
The two functions can be used to store and read from a JSON file the contact lists.
TODO
apt)